Source file src/cmd/compile/internal/types2/decl.go

     1  // Copyright 2014 The Go Authors. All rights reserved.
     2  // Use of this source code is governed by a BSD-style
     3  // license that can be found in the LICENSE file.
     4  
     5  package types2
     6  
     7  import (
     8  	"cmd/compile/internal/syntax"
     9  	"fmt"
    10  	"go/constant"
    11  	. "internal/types/errors"
    12  	"slices"
    13  )
    14  
    15  func (check *Checker) declare(scope *Scope, id *syntax.Name, obj Object, pos syntax.Pos) {
    16  	// spec: "The blank identifier, represented by the underscore
    17  	// character _, may be used in a declaration like any other
    18  	// identifier but the declaration does not introduce a new
    19  	// binding."
    20  	if obj.Name() != "_" {
    21  		if alt := scope.Insert(obj); alt != nil {
    22  			err := check.newError(DuplicateDecl)
    23  			err.addf(obj, "%s redeclared in this block", obj.Name())
    24  			err.addAltDecl(alt)
    25  			err.report()
    26  			return
    27  		}
    28  		obj.setScopePos(pos)
    29  	}
    30  	if id != nil {
    31  		check.recordDef(id, obj)
    32  	}
    33  }
    34  
    35  // pathString returns a string of the form a->b-> ... ->g for a path [a, b, ... g].
    36  func pathString(path []Object) string {
    37  	var s string
    38  	for i, p := range path {
    39  		if i > 0 {
    40  			s += "->"
    41  		}
    42  		s += p.Name()
    43  	}
    44  	return s
    45  }
    46  
    47  // objDecl type-checks the declaration of obj in its respective (file) environment.
    48  // For the meaning of def, see Checker.definedType, in typexpr.go.
    49  func (check *Checker) objDecl(obj Object, def *TypeName) {
    50  	if tracePos {
    51  		check.pushPos(obj.Pos())
    52  		defer func() {
    53  			// If we're panicking, keep stack of source positions.
    54  			if p := recover(); p != nil {
    55  				panic(p)
    56  			}
    57  			check.popPos()
    58  		}()
    59  	}
    60  
    61  	if check.conf.Trace && obj.Type() == nil {
    62  		if check.indent == 0 {
    63  			fmt.Println() // empty line between top-level objects for readability
    64  		}
    65  		check.trace(obj.Pos(), "-- checking %s (%s, objPath = %s)", obj, obj.color(), pathString(check.objPath))
    66  		check.indent++
    67  		defer func() {
    68  			check.indent--
    69  			check.trace(obj.Pos(), "=> %s (%s)", obj, obj.color())
    70  		}()
    71  	}
    72  
    73  	// Checking the declaration of obj means inferring its type
    74  	// (and possibly its value, for constants).
    75  	// An object's type (and thus the object) may be in one of
    76  	// three states which are expressed by colors:
    77  	//
    78  	// - an object whose type is not yet known is painted white (initial color)
    79  	// - an object whose type is in the process of being inferred is painted grey
    80  	// - an object whose type is fully inferred is painted black
    81  	//
    82  	// During type inference, an object's color changes from white to grey
    83  	// to black (pre-declared objects are painted black from the start).
    84  	// A black object (i.e., its type) can only depend on (refer to) other black
    85  	// ones. White and grey objects may depend on white and black objects.
    86  	// A dependency on a grey object indicates a cycle which may or may not be
    87  	// valid.
    88  	//
    89  	// When objects turn grey, they are pushed on the object path (a stack);
    90  	// they are popped again when they turn black. Thus, if a grey object (a
    91  	// cycle) is encountered, it is on the object path, and all the objects
    92  	// it depends on are the remaining objects on that path. Color encoding
    93  	// is such that the color value of a grey object indicates the index of
    94  	// that object in the object path.
    95  
    96  	// During type-checking, white objects may be assigned a type without
    97  	// traversing through objDecl; e.g., when initializing constants and
    98  	// variables. Update the colors of those objects here (rather than
    99  	// everywhere where we set the type) to satisfy the color invariants.
   100  	if obj.color() == white && obj.Type() != nil {
   101  		obj.setColor(black)
   102  		return
   103  	}
   104  
   105  	switch obj.color() {
   106  	case white:
   107  		assert(obj.Type() == nil)
   108  		// All color values other than white and black are considered grey.
   109  		// Because black and white are < grey, all values >= grey are grey.
   110  		// Use those values to encode the object's index into the object path.
   111  		obj.setColor(grey + color(check.push(obj)))
   112  		defer func() {
   113  			check.pop().setColor(black)
   114  		}()
   115  
   116  	case black:
   117  		assert(obj.Type() != nil)
   118  		return
   119  
   120  	default:
   121  		// Color values other than white or black are considered grey.
   122  		fallthrough
   123  
   124  	case grey:
   125  		// We have a (possibly invalid) cycle.
   126  		// In the existing code, this is marked by a non-nil type
   127  		// for the object except for constants and variables whose
   128  		// type may be non-nil (known), or nil if it depends on the
   129  		// not-yet known initialization value.
   130  		// In the former case, set the type to Typ[Invalid] because
   131  		// we have an initialization cycle. The cycle error will be
   132  		// reported later, when determining initialization order.
   133  		// TODO(gri) Report cycle here and simplify initialization
   134  		// order code.
   135  		switch obj := obj.(type) {
   136  		case *Const:
   137  			if !check.validCycle(obj) || obj.typ == nil {
   138  				obj.typ = Typ[Invalid]
   139  			}
   140  
   141  		case *Var:
   142  			if !check.validCycle(obj) || obj.typ == nil {
   143  				obj.typ = Typ[Invalid]
   144  			}
   145  
   146  		case *TypeName:
   147  			if !check.validCycle(obj) {
   148  				// break cycle
   149  				// (without this, calling underlying()
   150  				// below may lead to an endless loop
   151  				// if we have a cycle for a defined
   152  				// (*Named) type)
   153  				obj.typ = Typ[Invalid]
   154  			}
   155  
   156  		case *Func:
   157  			if !check.validCycle(obj) {
   158  				// Don't set obj.typ to Typ[Invalid] here
   159  				// because plenty of code type-asserts that
   160  				// functions have a *Signature type. Grey
   161  				// functions have their type set to an empty
   162  				// signature which makes it impossible to
   163  				// initialize a variable with the function.
   164  			}
   165  
   166  		default:
   167  			panic("unreachable")
   168  		}
   169  		assert(obj.Type() != nil)
   170  		return
   171  	}
   172  
   173  	d := check.objMap[obj]
   174  	if d == nil {
   175  		check.dump("%v: %s should have been declared", obj.Pos(), obj)
   176  		panic("unreachable")
   177  	}
   178  
   179  	// save/restore current environment and set up object environment
   180  	defer func(env environment) {
   181  		check.environment = env
   182  	}(check.environment)
   183  	check.environment = environment{scope: d.file, version: d.version}
   184  
   185  	// Const and var declarations must not have initialization
   186  	// cycles. We track them by remembering the current declaration
   187  	// in check.decl. Initialization expressions depending on other
   188  	// consts, vars, or functions, add dependencies to the current
   189  	// check.decl.
   190  	switch obj := obj.(type) {
   191  	case *Const:
   192  		check.decl = d // new package-level const decl
   193  		check.constDecl(obj, d.vtyp, d.init, d.inherited)
   194  	case *Var:
   195  		check.decl = d // new package-level var decl
   196  		check.varDecl(obj, d.lhs, d.vtyp, d.init)
   197  	case *TypeName:
   198  		// invalid recursive types are detected via path
   199  		check.typeDecl(obj, d.tdecl, def)
   200  		check.collectMethods(obj) // methods can only be added to top-level types
   201  	case *Func:
   202  		// functions may be recursive - no need to track dependencies
   203  		check.funcDecl(obj, d)
   204  	default:
   205  		panic("unreachable")
   206  	}
   207  }
   208  
   209  // validCycle reports whether the cycle starting with obj is valid and
   210  // reports an error if it is not.
   211  func (check *Checker) validCycle(obj Object) (valid bool) {
   212  	// The object map contains the package scope objects and the non-interface methods.
   213  	if debug {
   214  		info := check.objMap[obj]
   215  		inObjMap := info != nil && (info.fdecl == nil || info.fdecl.Recv == nil) // exclude methods
   216  		isPkgObj := obj.Parent() == check.pkg.scope
   217  		if isPkgObj != inObjMap {
   218  			check.dump("%v: inconsistent object map for %s (isPkgObj = %v, inObjMap = %v)", obj.Pos(), obj, isPkgObj, inObjMap)
   219  			panic("unreachable")
   220  		}
   221  	}
   222  
   223  	// Count cycle objects.
   224  	assert(obj.color() >= grey)
   225  	start := obj.color() - grey // index of obj in objPath
   226  	cycle := check.objPath[start:]
   227  	tparCycle := false // if set, the cycle is through a type parameter list
   228  	nval := 0          // number of (constant or variable) values in the cycle
   229  	ndef := 0          // number of type definitions in the cycle
   230  loop:
   231  	for _, obj := range cycle {
   232  		switch obj := obj.(type) {
   233  		case *Const, *Var:
   234  			nval++
   235  		case *TypeName:
   236  			// If we reach a generic type that is part of a cycle
   237  			// and we are in a type parameter list, we have a cycle
   238  			// through a type parameter list.
   239  			if check.inTParamList && isGeneric(obj.typ) {
   240  				tparCycle = true
   241  				break loop
   242  			}
   243  
   244  			// Determine if the type name is an alias or not. For
   245  			// package-level objects, use the object map which
   246  			// provides syntactic information (which doesn't rely
   247  			// on the order in which the objects are set up). For
   248  			// local objects, we can rely on the order, so use
   249  			// the object's predicate.
   250  			// TODO(gri) It would be less fragile to always access
   251  			// the syntactic information. We should consider storing
   252  			// this information explicitly in the object.
   253  			var alias bool
   254  			if check.conf.EnableAlias {
   255  				alias = obj.IsAlias()
   256  			} else {
   257  				if d := check.objMap[obj]; d != nil {
   258  					alias = d.tdecl.Alias // package-level object
   259  				} else {
   260  					alias = obj.IsAlias() // function local object
   261  				}
   262  			}
   263  			if !alias {
   264  				ndef++
   265  			}
   266  		case *Func:
   267  			// ignored for now
   268  		default:
   269  			panic("unreachable")
   270  		}
   271  	}
   272  
   273  	if check.conf.Trace {
   274  		check.trace(obj.Pos(), "## cycle detected: objPath = %s->%s (len = %d)", pathString(cycle), obj.Name(), len(cycle))
   275  		if tparCycle {
   276  			check.trace(obj.Pos(), "## cycle contains: generic type in a type parameter list")
   277  		} else {
   278  			check.trace(obj.Pos(), "## cycle contains: %d values, %d type definitions", nval, ndef)
   279  		}
   280  		defer func() {
   281  			if valid {
   282  				check.trace(obj.Pos(), "=> cycle is valid")
   283  			} else {
   284  				check.trace(obj.Pos(), "=> error: cycle is invalid")
   285  			}
   286  		}()
   287  	}
   288  
   289  	// Cycles through type parameter lists are ok (go.dev/issue/68162).
   290  	if tparCycle {
   291  		return true
   292  	}
   293  
   294  	// A cycle involving only constants and variables is invalid but we
   295  	// ignore them here because they are reported via the initialization
   296  	// cycle check.
   297  	if nval == len(cycle) {
   298  		return true
   299  	}
   300  
   301  	// A cycle involving only types (and possibly functions) must have at least
   302  	// one type definition to be permitted: If there is no type definition, we
   303  	// have a sequence of alias type names which will expand ad infinitum.
   304  	if nval == 0 && ndef > 0 {
   305  		return true
   306  	}
   307  
   308  	check.cycleError(cycle, firstInSrc(cycle))
   309  	return false
   310  }
   311  
   312  // cycleError reports a declaration cycle starting with the object at cycle[start].
   313  func (check *Checker) cycleError(cycle []Object, start int) {
   314  	// name returns the (possibly qualified) object name.
   315  	// This is needed because with generic types, cycles
   316  	// may refer to imported types. See go.dev/issue/50788.
   317  	// TODO(gri) This functionality is used elsewhere. Factor it out.
   318  	name := func(obj Object) string {
   319  		return packagePrefix(obj.Pkg(), check.qualifier) + obj.Name()
   320  	}
   321  
   322  	// If obj is a type alias, mark it as valid (not broken) in order to avoid follow-on errors.
   323  	obj := cycle[start]
   324  	tname, _ := obj.(*TypeName)
   325  	if tname != nil {
   326  		if check.conf.EnableAlias {
   327  			if a, ok := tname.Type().(*Alias); ok {
   328  				a.fromRHS = Typ[Invalid]
   329  			}
   330  		} else {
   331  			if tname.IsAlias() {
   332  				check.validAlias(tname, Typ[Invalid])
   333  			}
   334  		}
   335  	}
   336  
   337  	// report a more concise error for self references
   338  	if len(cycle) == 1 {
   339  		if tname != nil {
   340  			check.errorf(obj, InvalidDeclCycle, "invalid recursive type: %s refers to itself", name(obj))
   341  		} else {
   342  			check.errorf(obj, InvalidDeclCycle, "invalid cycle in declaration: %s refers to itself", name(obj))
   343  		}
   344  		return
   345  	}
   346  
   347  	err := check.newError(InvalidDeclCycle)
   348  	if tname != nil {
   349  		err.addf(obj, "invalid recursive type %s", name(obj))
   350  	} else {
   351  		err.addf(obj, "invalid cycle in declaration of %s", name(obj))
   352  	}
   353  	// "cycle[i] refers to cycle[j]" for (i,j) = (s,s+1), (s+1,s+2), ..., (n-1,0), (0,1), ..., (s-1,s) for len(cycle) = n, s = start.
   354  	for i := range cycle {
   355  		next := cycle[(start+i+1)%len(cycle)]
   356  		err.addf(obj, "%s refers to %s", name(obj), name(next))
   357  		obj = next
   358  	}
   359  	err.report()
   360  }
   361  
   362  // firstInSrc reports the index of the object with the "smallest"
   363  // source position in path. path must not be empty.
   364  func firstInSrc(path []Object) int {
   365  	fst, pos := 0, path[0].Pos()
   366  	for i, t := range path[1:] {
   367  		if cmpPos(t.Pos(), pos) < 0 {
   368  			fst, pos = i+1, t.Pos()
   369  		}
   370  	}
   371  	return fst
   372  }
   373  
   374  func (check *Checker) constDecl(obj *Const, typ, init syntax.Expr, inherited bool) {
   375  	assert(obj.typ == nil)
   376  
   377  	// use the correct value of iota and errpos
   378  	defer func(iota constant.Value, errpos syntax.Pos) {
   379  		check.iota = iota
   380  		check.errpos = errpos
   381  	}(check.iota, check.errpos)
   382  	check.iota = obj.val
   383  	check.errpos = nopos
   384  
   385  	// provide valid constant value under all circumstances
   386  	obj.val = constant.MakeUnknown()
   387  
   388  	// determine type, if any
   389  	if typ != nil {
   390  		t := check.typ(typ)
   391  		if !isConstType(t) {
   392  			// don't report an error if the type is an invalid C (defined) type
   393  			// (go.dev/issue/22090)
   394  			if isValid(t.Underlying()) {
   395  				check.errorf(typ, InvalidConstType, "invalid constant type %s", t)
   396  			}
   397  			obj.typ = Typ[Invalid]
   398  			return
   399  		}
   400  		obj.typ = t
   401  	}
   402  
   403  	// check initialization
   404  	var x operand
   405  	if init != nil {
   406  		if inherited {
   407  			// The initialization expression is inherited from a previous
   408  			// constant declaration, and (error) positions refer to that
   409  			// expression and not the current constant declaration. Use
   410  			// the constant identifier position for any errors during
   411  			// init expression evaluation since that is all we have
   412  			// (see issues go.dev/issue/42991, go.dev/issue/42992).
   413  			check.errpos = obj.pos
   414  		}
   415  		check.expr(nil, &x, init)
   416  	}
   417  	check.initConst(obj, &x)
   418  }
   419  
   420  func (check *Checker) varDecl(obj *Var, lhs []*Var, typ, init syntax.Expr) {
   421  	assert(obj.typ == nil)
   422  
   423  	// determine type, if any
   424  	if typ != nil {
   425  		obj.typ = check.varType(typ)
   426  		// We cannot spread the type to all lhs variables if there
   427  		// are more than one since that would mark them as checked
   428  		// (see Checker.objDecl) and the assignment of init exprs,
   429  		// if any, would not be checked.
   430  		//
   431  		// TODO(gri) If we have no init expr, we should distribute
   432  		// a given type otherwise we need to re-evaluate the type
   433  		// expr for each lhs variable, leading to duplicate work.
   434  	}
   435  
   436  	// check initialization
   437  	if init == nil {
   438  		if typ == nil {
   439  			// error reported before by arityMatch
   440  			obj.typ = Typ[Invalid]
   441  		}
   442  		return
   443  	}
   444  
   445  	if lhs == nil || len(lhs) == 1 {
   446  		assert(lhs == nil || lhs[0] == obj)
   447  		var x operand
   448  		check.expr(newTarget(obj.typ, obj.name), &x, init)
   449  		check.initVar(obj, &x, "variable declaration")
   450  		return
   451  	}
   452  
   453  	if debug {
   454  		// obj must be one of lhs
   455  		if !slices.Contains(lhs, obj) {
   456  			panic("inconsistent lhs")
   457  		}
   458  	}
   459  
   460  	// We have multiple variables on the lhs and one init expr.
   461  	// Make sure all variables have been given the same type if
   462  	// one was specified, otherwise they assume the type of the
   463  	// init expression values (was go.dev/issue/15755).
   464  	if typ != nil {
   465  		for _, lhs := range lhs {
   466  			lhs.typ = obj.typ
   467  		}
   468  	}
   469  
   470  	check.initVars(lhs, []syntax.Expr{init}, nil)
   471  }
   472  
   473  // isImportedConstraint reports whether typ is an imported type constraint.
   474  func (check *Checker) isImportedConstraint(typ Type) bool {
   475  	named := asNamed(typ)
   476  	if named == nil || named.obj.pkg == check.pkg || named.obj.pkg == nil {
   477  		return false
   478  	}
   479  	u, _ := named.Underlying().(*Interface)
   480  	return u != nil && !u.IsMethodSet()
   481  }
   482  
   483  func (check *Checker) typeDecl(obj *TypeName, tdecl *syntax.TypeDecl, def *TypeName) {
   484  	assert(obj.typ == nil)
   485  
   486  	// Only report a version error if we have not reported one already.
   487  	versionErr := false
   488  
   489  	var rhs Type
   490  	check.later(func() {
   491  		if t := asNamed(obj.typ); t != nil { // type may be invalid
   492  			check.validType(t)
   493  		}
   494  		// If typ is local, an error was already reported where typ is specified/defined.
   495  		_ = !versionErr && check.isImportedConstraint(rhs) && check.verifyVersionf(tdecl.Type, go1_18, "using type constraint %s", rhs)
   496  	}).describef(obj, "validType(%s)", obj.Name())
   497  
   498  	// First type parameter, or nil.
   499  	var tparam0 *syntax.Field
   500  	if len(tdecl.TParamList) > 0 {
   501  		tparam0 = tdecl.TParamList[0]
   502  	}
   503  
   504  	// alias declaration
   505  	if tdecl.Alias {
   506  		// Report highest version requirement first so that fixing a version issue
   507  		// avoids possibly two -lang changes (first to Go 1.9 and then to Go 1.23).
   508  		if !versionErr && tparam0 != nil && !check.verifyVersionf(tparam0, go1_23, "generic type alias") {
   509  			versionErr = true
   510  		}
   511  		if !versionErr && !check.verifyVersionf(tdecl, go1_9, "type alias") {
   512  			versionErr = true
   513  		}
   514  
   515  		if check.conf.EnableAlias {
   516  			alias := check.newAlias(obj, nil)
   517  			setDefType(def, alias)
   518  
   519  			// If we could not type the RHS, set it to invalid. This should
   520  			// only ever happen if we panic before setting.
   521  			defer func() {
   522  				if alias.fromRHS == nil {
   523  					alias.fromRHS = Typ[Invalid]
   524  					unalias(alias)
   525  				}
   526  			}()
   527  
   528  			// handle type parameters even if not allowed (Alias type is supported)
   529  			if tparam0 != nil {
   530  				check.openScope(tdecl, "type parameters")
   531  				defer check.closeScope()
   532  				check.collectTypeParams(&alias.tparams, tdecl.TParamList)
   533  			}
   534  
   535  			rhs = check.definedType(tdecl.Type, obj)
   536  			assert(rhs != nil)
   537  
   538  			alias.fromRHS = rhs
   539  			unalias(alias) // resolve alias.actual
   540  		} else {
   541  			if !versionErr && tparam0 != nil {
   542  				check.error(tdecl, UnsupportedFeature, "generic type alias requires GODEBUG=gotypesalias=1 or unset")
   543  				versionErr = true
   544  			}
   545  
   546  			check.brokenAlias(obj)
   547  			rhs = check.typ(tdecl.Type)
   548  			check.validAlias(obj, rhs)
   549  		}
   550  		return
   551  	}
   552  
   553  	// type definition or generic type declaration
   554  	if !versionErr && tparam0 != nil && !check.verifyVersionf(tparam0, go1_18, "type parameter") {
   555  		versionErr = true
   556  	}
   557  
   558  	named := check.newNamed(obj, nil, nil)
   559  	setDefType(def, named)
   560  
   561  	// The RHS of a named N can be nil if, for example, N is defined as a cycle of aliases with
   562  	// gotypesalias=0. Consider:
   563  	//
   564  	//   type D N    // N.resolve() will panic
   565  	//   type N A
   566  	//   type A = N  // N.fromRHS is not set before N.resolve(), since A does not call setDefType
   567  	//
   568  	// There is likely a better way to detect such cases, but it may not be worth the effort.
   569  	// Instead, we briefly permit a nil N.fromRHS while type-checking D.
   570  	named.allowNilRHS = true
   571  	defer (func() { named.allowNilRHS = false })()
   572  
   573  	if tdecl.TParamList != nil {
   574  		check.openScope(tdecl, "type parameters")
   575  		defer check.closeScope()
   576  		check.collectTypeParams(&named.tparams, tdecl.TParamList)
   577  	}
   578  
   579  	rhs = check.definedType(tdecl.Type, obj)
   580  	assert(rhs != nil)
   581  	named.fromRHS = rhs
   582  
   583  	// spec: "In a type definition the given type cannot be a type parameter."
   584  	// (See also go.dev/issue/45639.)
   585  	if isTypeParam(rhs) {
   586  		check.error(tdecl.Type, MisplacedTypeParam, "cannot use a type parameter as RHS in type declaration")
   587  		named.fromRHS = Typ[Invalid]
   588  	}
   589  }
   590  
   591  func (check *Checker) collectTypeParams(dst **TypeParamList, list []*syntax.Field) {
   592  	tparams := make([]*TypeParam, len(list))
   593  
   594  	// Declare type parameters up-front.
   595  	// The scope of type parameters starts at the beginning of the type parameter
   596  	// list (so we can have mutually recursive parameterized type bounds).
   597  	if len(list) > 0 {
   598  		scopePos := list[0].Pos()
   599  		for i, f := range list {
   600  			tparams[i] = check.declareTypeParam(f.Name, scopePos)
   601  		}
   602  	}
   603  
   604  	// Set the type parameters before collecting the type constraints because
   605  	// the parameterized type may be used by the constraints (go.dev/issue/47887).
   606  	// Example: type T[P T[P]] interface{}
   607  	*dst = bindTParams(tparams)
   608  
   609  	// Signal to cycle detection that we are in a type parameter list.
   610  	// We can only be inside one type parameter list at any given time:
   611  	// function closures may appear inside a type parameter list but they
   612  	// cannot be generic, and their bodies are processed in delayed and
   613  	// sequential fashion. Note that with each new declaration, we save
   614  	// the existing environment and restore it when done; thus inTParamList
   615  	// is true exactly only when we are in a specific type parameter list.
   616  	assert(!check.inTParamList)
   617  	check.inTParamList = true
   618  	defer func() {
   619  		check.inTParamList = false
   620  	}()
   621  
   622  	// Keep track of bounds for later validation.
   623  	var bound Type
   624  	for i, f := range list {
   625  		// Optimization: Re-use the previous type bound if it hasn't changed.
   626  		// This also preserves the grouped output of type parameter lists
   627  		// when printing type strings.
   628  		if i == 0 || f.Type != list[i-1].Type {
   629  			bound = check.bound(f.Type)
   630  			if isTypeParam(bound) {
   631  				// We may be able to allow this since it is now well-defined what
   632  				// the underlying type and thus type set of a type parameter is.
   633  				// But we may need some additional form of cycle detection within
   634  				// type parameter lists.
   635  				check.error(f.Type, MisplacedTypeParam, "cannot use a type parameter as constraint")
   636  				bound = Typ[Invalid]
   637  			}
   638  		}
   639  		tparams[i].bound = bound
   640  	}
   641  }
   642  
   643  func (check *Checker) bound(x syntax.Expr) Type {
   644  	// A type set literal of the form ~T and A|B may only appear as constraint;
   645  	// embed it in an implicit interface so that only interface type-checking
   646  	// needs to take care of such type expressions.
   647  	if op, _ := x.(*syntax.Operation); op != nil && (op.Op == syntax.Tilde || op.Op == syntax.Or) {
   648  		t := check.typ(&syntax.InterfaceType{MethodList: []*syntax.Field{{Type: x}}})
   649  		// mark t as implicit interface if all went well
   650  		if t, _ := t.(*Interface); t != nil {
   651  			t.implicit = true
   652  		}
   653  		return t
   654  	}
   655  	return check.typ(x)
   656  }
   657  
   658  func (check *Checker) declareTypeParam(name *syntax.Name, scopePos syntax.Pos) *TypeParam {
   659  	// Use Typ[Invalid] for the type constraint to ensure that a type
   660  	// is present even if the actual constraint has not been assigned
   661  	// yet.
   662  	// TODO(gri) Need to systematically review all uses of type parameter
   663  	//           constraints to make sure we don't rely on them if they
   664  	//           are not properly set yet.
   665  	tname := NewTypeName(name.Pos(), check.pkg, name.Value, nil)
   666  	tpar := check.newTypeParam(tname, Typ[Invalid]) // assigns type to tname as a side-effect
   667  	check.declare(check.scope, name, tname, scopePos)
   668  	return tpar
   669  }
   670  
   671  func (check *Checker) collectMethods(obj *TypeName) {
   672  	// get associated methods
   673  	// (Checker.collectObjects only collects methods with non-blank names;
   674  	// Checker.resolveBaseTypeName ensures that obj is not an alias name
   675  	// if it has attached methods.)
   676  	methods := check.methods[obj]
   677  	if methods == nil {
   678  		return
   679  	}
   680  	delete(check.methods, obj)
   681  	assert(!check.objMap[obj].tdecl.Alias) // don't use TypeName.IsAlias (requires fully set up object)
   682  
   683  	// use an objset to check for name conflicts
   684  	var mset objset
   685  
   686  	// spec: "If the base type is a struct type, the non-blank method
   687  	// and field names must be distinct."
   688  	base := asNamed(obj.typ) // shouldn't fail but be conservative
   689  	if base != nil {
   690  		assert(base.TypeArgs().Len() == 0) // collectMethods should not be called on an instantiated type
   691  
   692  		// See go.dev/issue/52529: we must delay the expansion of underlying here, as
   693  		// base may not be fully set-up.
   694  		check.later(func() {
   695  			check.checkFieldUniqueness(base)
   696  		}).describef(obj, "verifying field uniqueness for %v", base)
   697  
   698  		// Checker.Files may be called multiple times; additional package files
   699  		// may add methods to already type-checked types. Add pre-existing methods
   700  		// so that we can detect redeclarations.
   701  		for i := 0; i < base.NumMethods(); i++ {
   702  			m := base.Method(i)
   703  			assert(m.name != "_")
   704  			assert(mset.insert(m) == nil)
   705  		}
   706  	}
   707  
   708  	// add valid methods
   709  	for _, m := range methods {
   710  		// spec: "For a base type, the non-blank names of methods bound
   711  		// to it must be unique."
   712  		assert(m.name != "_")
   713  		if alt := mset.insert(m); alt != nil {
   714  			if alt.Pos().IsKnown() {
   715  				check.errorf(m.pos, DuplicateMethod, "method %s.%s already declared at %v", obj.Name(), m.name, alt.Pos())
   716  			} else {
   717  				check.errorf(m.pos, DuplicateMethod, "method %s.%s already declared", obj.Name(), m.name)
   718  			}
   719  			continue
   720  		}
   721  
   722  		if base != nil {
   723  			base.AddMethod(m)
   724  		}
   725  	}
   726  }
   727  
   728  func (check *Checker) checkFieldUniqueness(base *Named) {
   729  	if t, _ := base.Underlying().(*Struct); t != nil {
   730  		var mset objset
   731  		for i := 0; i < base.NumMethods(); i++ {
   732  			m := base.Method(i)
   733  			assert(m.name != "_")
   734  			assert(mset.insert(m) == nil)
   735  		}
   736  
   737  		// Check that any non-blank field names of base are distinct from its
   738  		// method names.
   739  		for _, fld := range t.fields {
   740  			if fld.name != "_" {
   741  				if alt := mset.insert(fld); alt != nil {
   742  					// Struct fields should already be unique, so we should only
   743  					// encounter an alternate via collision with a method name.
   744  					_ = alt.(*Func)
   745  
   746  					// For historical consistency, we report the primary error on the
   747  					// method, and the alt decl on the field.
   748  					err := check.newError(DuplicateFieldAndMethod)
   749  					err.addf(alt, "field and method with the same name %s", fld.name)
   750  					err.addAltDecl(fld)
   751  					err.report()
   752  				}
   753  			}
   754  		}
   755  	}
   756  }
   757  
   758  func (check *Checker) funcDecl(obj *Func, decl *declInfo) {
   759  	assert(obj.typ == nil)
   760  
   761  	// func declarations cannot use iota
   762  	assert(check.iota == nil)
   763  
   764  	sig := new(Signature)
   765  	obj.typ = sig // guard against cycles
   766  
   767  	// Avoid cycle error when referring to method while type-checking the signature.
   768  	// This avoids a nuisance in the best case (non-parameterized receiver type) and
   769  	// since the method is not a type, we get an error. If we have a parameterized
   770  	// receiver type, instantiating the receiver type leads to the instantiation of
   771  	// its methods, and we don't want a cycle error in that case.
   772  	// TODO(gri) review if this is correct and/or whether we still need this?
   773  	saved := obj.color_
   774  	obj.color_ = black
   775  	fdecl := decl.fdecl
   776  	check.funcType(sig, fdecl.Recv, fdecl.TParamList, fdecl.Type)
   777  	obj.color_ = saved
   778  
   779  	// Set the scope's extent to the complete "func (...) { ... }"
   780  	// so that Scope.Innermost works correctly.
   781  	sig.scope.pos = fdecl.Pos()
   782  	sig.scope.end = syntax.EndPos(fdecl)
   783  
   784  	if len(fdecl.TParamList) > 0 && fdecl.Body == nil {
   785  		check.softErrorf(fdecl, BadDecl, "generic function is missing function body")
   786  	}
   787  
   788  	// function body must be type-checked after global declarations
   789  	// (functions implemented elsewhere have no body)
   790  	if !check.conf.IgnoreFuncBodies && fdecl.Body != nil {
   791  		check.later(func() {
   792  			check.funcBody(decl, obj.name, sig, fdecl.Body, nil)
   793  		}).describef(obj, "func %s", obj.name)
   794  	}
   795  }
   796  
   797  func (check *Checker) declStmt(list []syntax.Decl) {
   798  	pkg := check.pkg
   799  
   800  	first := -1                // index of first ConstDecl in the current group, or -1
   801  	var last *syntax.ConstDecl // last ConstDecl with init expressions, or nil
   802  	for index, decl := range list {
   803  		if _, ok := decl.(*syntax.ConstDecl); !ok {
   804  			first = -1 // we're not in a constant declaration
   805  		}
   806  
   807  		switch s := decl.(type) {
   808  		case *syntax.ConstDecl:
   809  			top := len(check.delayed)
   810  
   811  			// iota is the index of the current constDecl within the group
   812  			if first < 0 || s.Group == nil || list[index-1].(*syntax.ConstDecl).Group != s.Group {
   813  				first = index
   814  				last = nil
   815  			}
   816  			iota := constant.MakeInt64(int64(index - first))
   817  
   818  			// determine which initialization expressions to use
   819  			inherited := true
   820  			switch {
   821  			case s.Type != nil || s.Values != nil:
   822  				last = s
   823  				inherited = false
   824  			case last == nil:
   825  				last = new(syntax.ConstDecl) // make sure last exists
   826  				inherited = false
   827  			}
   828  
   829  			// declare all constants
   830  			lhs := make([]*Const, len(s.NameList))
   831  			values := syntax.UnpackListExpr(last.Values)
   832  			for i, name := range s.NameList {
   833  				obj := NewConst(name.Pos(), pkg, name.Value, nil, iota)
   834  				lhs[i] = obj
   835  
   836  				var init syntax.Expr
   837  				if i < len(values) {
   838  					init = values[i]
   839  				}
   840  
   841  				check.constDecl(obj, last.Type, init, inherited)
   842  			}
   843  
   844  			// Constants must always have init values.
   845  			check.arity(s.Pos(), s.NameList, values, true, inherited)
   846  
   847  			// process function literals in init expressions before scope changes
   848  			check.processDelayed(top)
   849  
   850  			// spec: "The scope of a constant or variable identifier declared
   851  			// inside a function begins at the end of the ConstSpec or VarSpec
   852  			// (ShortVarDecl for short variable declarations) and ends at the
   853  			// end of the innermost containing block."
   854  			scopePos := syntax.EndPos(s)
   855  			for i, name := range s.NameList {
   856  				check.declare(check.scope, name, lhs[i], scopePos)
   857  			}
   858  
   859  		case *syntax.VarDecl:
   860  			top := len(check.delayed)
   861  
   862  			lhs0 := make([]*Var, len(s.NameList))
   863  			for i, name := range s.NameList {
   864  				lhs0[i] = newVar(LocalVar, name.Pos(), pkg, name.Value, nil)
   865  			}
   866  
   867  			// initialize all variables
   868  			values := syntax.UnpackListExpr(s.Values)
   869  			for i, obj := range lhs0 {
   870  				var lhs []*Var
   871  				var init syntax.Expr
   872  				switch len(values) {
   873  				case len(s.NameList):
   874  					// lhs and rhs match
   875  					init = values[i]
   876  				case 1:
   877  					// rhs is expected to be a multi-valued expression
   878  					lhs = lhs0
   879  					init = values[0]
   880  				default:
   881  					if i < len(values) {
   882  						init = values[i]
   883  					}
   884  				}
   885  				check.varDecl(obj, lhs, s.Type, init)
   886  				if len(values) == 1 {
   887  					// If we have a single lhs variable we are done either way.
   888  					// If we have a single rhs expression, it must be a multi-
   889  					// valued expression, in which case handling the first lhs
   890  					// variable will cause all lhs variables to have a type
   891  					// assigned, and we are done as well.
   892  					if debug {
   893  						for _, obj := range lhs0 {
   894  							assert(obj.typ != nil)
   895  						}
   896  					}
   897  					break
   898  				}
   899  			}
   900  
   901  			// If we have no type, we must have values.
   902  			if s.Type == nil || values != nil {
   903  				check.arity(s.Pos(), s.NameList, values, false, false)
   904  			}
   905  
   906  			// process function literals in init expressions before scope changes
   907  			check.processDelayed(top)
   908  
   909  			// declare all variables
   910  			// (only at this point are the variable scopes (parents) set)
   911  			scopePos := syntax.EndPos(s) // see constant declarations
   912  			for i, name := range s.NameList {
   913  				// see constant declarations
   914  				check.declare(check.scope, name, lhs0[i], scopePos)
   915  			}
   916  
   917  		case *syntax.TypeDecl:
   918  			obj := NewTypeName(s.Name.Pos(), pkg, s.Name.Value, nil)
   919  			// spec: "The scope of a type identifier declared inside a function
   920  			// begins at the identifier in the TypeSpec and ends at the end of
   921  			// the innermost containing block."
   922  			scopePos := s.Name.Pos()
   923  			check.declare(check.scope, s.Name, obj, scopePos)
   924  			// mark and unmark type before calling typeDecl; its type is still nil (see Checker.objDecl)
   925  			obj.setColor(grey + color(check.push(obj)))
   926  			check.typeDecl(obj, s, nil)
   927  			check.pop().setColor(black)
   928  
   929  		default:
   930  			check.errorf(s, InvalidSyntaxTree, "unknown syntax.Decl node %T", s)
   931  		}
   932  	}
   933  }
   934  

View as plain text